NSLS2 / NSLS2/pyCHX

Why is there a get_max_countc?

Open
#62 0 comments 0 reactions 3 assignees View on GitHub

@xmchenGH is already working on this.

Since Feb 12, 2021.

_commonspeckle question V2
Dominant language
Jupyter Notebook
Stars
8
Forks
12
Avg merge
2h 53m
Merged PRs (30d)
6

Description

It seems like there is a function in skbeam.roi that handles compressed data in the lowest level function for visibility (xsvsc_single())?

https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/chx_specklecp.py#L254-L255

Is this skbeam function wrong? Or was this an effort to have more control for technical reason specific to the CHX detector?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.