Delete functions from DEVS that are deployed in production modules
Open
Nobody has claimed this yet.
V3
- Dominant language
- Jupyter Notebook
- Stars
- 8
- Forks
- 12
- Avg merge
- 2h 53m
- Merged PRs (30d)
- 6
Description
DEVS looks to be a proving ground. Sometimes those functions are deleted when they are deployed to "live" modules. Sometimes it is not. I've compared functions and will list here findings.
very safe to delete from DEVS.py
- fit_one_peak_curve ; better function in
chi_generic_functionshttps://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/chx_generic_functions.py#L74 - plot_xy_with_fit ; same function in
chi_generic_functionshttps://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/chx_generic_functions.py#L114 - next function goes here......
need expert eye
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DEVS.py and compare the listed functions against their counterparts in chx_generic_functions.py, including the referenced definitions. Confirm which functions are deployed in production modules and which duplicates are safe to remove; done means the agreed duplicate functions are deleted without removing needed production behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100