multiple instances of function/variable `ps` for different purposes
@mrakitin is already working on this.
Since Feb 9, 2021.
- Dominant language
- Jupyter Notebook
- Stars
- 8
- Forks
- 12
- Avg merge
- 2h 53m
- Merged PRs (30d)
- 6
Description
"ps" is used for different things in the code base.
- instance 1, related to peak center
ps = based on original peak stats ; used in collection environment. may be useful in analysis. - instance 2, related to aged g2 from two-time
ps = - instance 3a,
get_timepixel_datacomment on line 36
ps = - instance 3b,
get_pvlist_from_postinternal variable that is returned
ps = - instance 4, speckle modules with variable
ps = Poission distribution. Docstring is good. no clarification needed
Instance 1
There are notes in code to @mrakitin .
Is this used in analysis to not have to fit to find the center of a peak?
It seems it was associated with a Bluesky profile file. Is this new one used in bluesky?
What does "ps" mean in this context? peak stats? peak scaling?
Instance 2
show_g12q_aged_g2()
https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/Two_Time_Correlation_Function.py#L599-L621
Instance(s) 3
in xpcs_timepixelmodule in 2 functions
https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/xpcs_timepixel.py#L25-L36
"ps" is photon statitisics?
https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/xpcs_timepixel.py#L50-L72
"ps" is photon positions
Instance 4
in speckle* modules for fit_xsvs1. "ps" is Poisson distribution
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.