resolve poisson and gamma distributions between _commonspeckle and skbeam
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 8
- Forks
- 12
- Avg merge
- 2h 53m
- Merged PRs (30d)
- 6
Description
Neet to address differences in two distribution functions.
- gamma distribution
- poisson distribution
Gamma Distribution
_commonspeckle
(lines 472-474 are completely different)
https://github.com/NSLS-II/pyCHX/blob/2ecdacf0dd8496dd8e90bb4975273b59e1d08e26/pyCHX/v2/_commonspeckle/chx_speckle.py#L471-L475
skbeam
Poisson Distribution
_commonspeckle
(make sure K is a float)
https://github.com/NSLS-II/pyCHX/blob/2ecdacf0dd8496dd8e90bb4975273b59e1d08e26/pyCHX/v2/_commonspeckle/chx_speckle.py#L545-L550
skbeam
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the cited implementations in _commonspeckle/chx_speckle.py and skbeam/core/fitting/lineshapes.py, focusing on the gamma and poisson distribution sections. Confirm the gamma discrepancy and resolve the unchecked poisson difference, including the note that K must be a float. Done means the two distribution implementations agree on the intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100