speckle visibility - consolidate code
Open
@ambarb is already working on this.
Since Feb 5, 2021.
_commonspeckle
V2
- Dominant language
- Jupyter Notebook
- Stars
- 8
- Forks
- 12
- Avg merge
- 2h 53m
- Merged PRs (30d)
- 6
Description
_commonspeckle.chx_speckle
- What are the differences between CHX's visiblity for
framesimage arraychx_speckleand skbeam's visiblity - resolve differences by bringing in nice features/comment into
_common.chx_specklefromskbeam.core.specklehttps://github.com/NSLS-II/pyCHX/issues/55 - fix any compressed only data in
_common.chx_speckle, which is for arrays - patch / add deprecation warning / remove same functions in
_common.chx_speckle - move plotting to new plotting module
_common.chx_speckle - understand how/if to import distribution functions from
skbeam.fitting.lineshapesnot ready for straight import yet https://github.com/NSLS-II/pyCHX/issues/54 - Can we use
skbeam.core.accumulatorshere as best as we can. It is used elsewhere inpyCHX
_commonspeckle.chx_specklecp
- Can we combine CHX's visibility for frame arrays and CHX's visiblity for compressed data & parallelized?
- reconcile _process (histogram versus bincount)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.