NSLS2 / NSLS2/pyCHX

Move olog report functions to databroker or bluesky or someother NSLS-ii repo for all?

Open
#49 1 comment 0 reactions 2 assignees View on GitHub

@ambarb is already working on this.

Since Feb 2, 2021.

_commonspeckle _futurepyCHX question V2
Dominant language
Jupyter Notebook
Stars
8
Forks
12
Avg merge
2h 53m
Merged PRs (30d)
6

Description

https://github.com/NSLS-II/pyCHX/blob/master/pyCHX/v2/_commonspeckle/chx_olog.py

What are the implications to CHX for us doing this?
Seems like it is a good thing for everyone to have?

@danielballan Can you evaluate and get DAMA's input.

  • delete module from _commonspeckle
  • decide between
    - keep in_futurepyCHX and then either direct copy or import into CSXtools
    - delete from _futurepyCHX and import from NSLS-ii common library TBD

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.