NSLS2 / NSLS2/pyCHX

handlers seems to have no active function, delete module??

Open
#48 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

_commonspeckle _futurepyCHX question V2
Dominant language
Jupyter Notebook
Stars
8
Forks
12
Avg merge
2h 53m
Merged PRs (30d)
6

Description

Noticed a comment:
https://github.com/NSLS-II/pyCHX/blob/2ecdacf0dd8496dd8e90bb4975273b59e1d08e26/pyCHX/v2/_commonspeckle/chx_handlers.py#L18-L21

This basically applies to the entire module. We should decide what to do on this.

  • Delete from _commonspeckle
  • Delete or fix for _futurepyCHX

@danielballan can you comment on this usage at SDCC versus CHX servers
I am voting for delete from _commonspeckle

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read pyCHX/v2/_commonspeckle/chx_handlers.py, especially the comment at lines 18-21, and inspect the corresponding _futurepyCHX code. Check the referenced usage at SDCC versus CHX servers, then resolve the checklist by deciding whether the modules should be deleted or fixed.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.