NSLS2 / NSLS2/pyCHX

[V1] likely broken import of XPCS_XSVS_SAXS_Multi_2017_V4 - obsolete? can delete?

Open
#45 1 comment 0 reactions 1 assignee View on GitHub

@afluerasu is already working on this.

Since Oct 22, 2020.

bug question V1 V2
Dominant language
Jupyter Notebook
Stars
8
Forks
12
Avg merge
2h 53m
Merged PRs (30d)
6

Description

https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/XPCS_XSVS_SAXS_Multi_2017_V4.py#L5

Show it relies on a function from a package that does not exist. should import as

from pyCHX.chx_xpcs_xsvs_jupyter_V1 import run_xpcs_xsvs_single 

I did not discover in V1 (pyCHX), but found this to be the case in the default copies of V2 (pyCHX.v2._commonspeckle).

Is this module XPCS_XSVS_SAXS_Multi_2017_V4 still requiring use or can it be deleted because it is obsolete?
If still required, then we can discuss further

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.