NSLS2 / NSLS2/pyCHX

[v2][_commonspeckle] what about functions for SMI?

Open
#42 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

_commonspeckle Q-space question V2
Dominant language
Jupyter Notebook
Stars
8
Forks
12
Avg merge
2h 53m
Merged PRs (30d)
6

Description

Do we need to keep, incorporate into CHX function, or create a generic scattering

There is WAXS stuff too, but treated basically the same as SAXS?

[abarbour@box64-2 ~/Repos/pyCHX/pyCHX/v2/_commonspeckle ✗ ] $ grep -n SMI *
DataGonio.py:567:        For SMI, because only rotate along y-axis, (det_theta_g=0.), only care about 
Stitching.py:10:              '''YG Sep 26, 2017 @SMI
Stitching.py:40:          For SMI, overlap_width = 85  #for calibration data--Kevin gives one, 4  degree 
Stitching.py:42:    For SMI:
Stitching.py:152:    phis: for SMI, the rotation angle around z-aixs
Stitching.py:153:    For SMI
Stitching.py:227:    '''YG. Sep 27@SMI
Stitching.py:253:    '''YG Sep 27@SMI
Stitching.py:254:    Get q_range, [ qx_start, qx_end, qz_start, qz_end ] for SMI WAXS qmap 
Stitching.py:305:    Get q_range, [ qx_start, qx_end, qz_start, qz_end ] for SMI WAXS qmap 
Stitching.py:352:    phis: for SMI, the rotation angle around z-aixs
Stitching.py:353:    For SMI
XPCS_GiSAXS.py:515:    ''' Nov 19, 2018@SMI to get alphaf and thetaf for gi scattering 

Probably matching function definitions:

DataGonio.py:551:     def set_angles(self, det_phi_g=0., det_theta_g=0., 
Stitching.py:9:       def get_base_all_filenames( inDir, base_filename_cut_length = -7  ):
Stitching.py:38:      def check_stitch_two_imgs( img1, img2, overlap_width, badpixel_width =10 ):
Stitching.py:147:     def stitch_WAXS_in_Qspace( dataM, phis, calibration, 
Stitching.py:226:     def plot_qmap_in_folder( inDir ): #TODO is this made for SMI as per docstring?
Stitching.py:252:     def get_qmap_range( calibration, phi_min, phi_max ):
Stitching.py:300:     def get_qmap_qxyz_range( calibration, det_theta_g_lim, det_phi_g_lim, 
Stitching.py:344:     def stitch_WAXS_in_Qspace_CHX( data, angle_dict, calibration, vary_angle='phi',
XPCS_GiSAXS.py:512:   def get_alphaf_thetaf( inc_x0, inc_y0, inc_ang, inc_phi = 0, 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the matching definitions in DataGonio.py, Stitching.py, and XPCS_GiSAXS.py, especially set_angles, stitch_WAXS_in_Qspace, stitch_WAXS_in_Qspace_CHX, and get_alphaf_thetaf. Review their SMI, WAXS, and SAXS references first; done requires an agreed decision on retaining, incorporating, or generalizing the functions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
18/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.