[v2][_commonspeckle][chx_correlation] 1t-from-2t is broken
Open
@tankonst is already working on this.
Since Oct 22, 2020.
_commonspeckle
discussion
V2
- Dominant language
- Jupyter Notebook
- Stars
- 8
- Forks
- 12
- Avg merge
- 2h 53m
- Merged PRs (30d)
- 6
Description
Note here to remember that this is broken but fixed and enhanced in scikit-beam + better testing.
https://github.com/scikit-beam/scikit-beam/pull/566
https://github.com/scikit-beam/scikit-beam/pull/571
However, equivalent (and with more options) exists already in
pyCHX.Two_Time_Correlation_Functions.get_one_time_from_two_timepyCHX.Two_Time_Correlation_Functions.get_one_time_from_two_time_old
We need to just consider adding error bar functionality as done by @tankonst https://github.com/scikit-beam/scikit-beam/pull/571
any objections to error bars?
discussion on returned data format?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.