Evaluate merging calls to AD servers
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 13
- Avg merge
- 1h 17m
- Merged PRs (30d)
- 1
Description
Nsls2Api fetches information for some models from BNL's AD server round-robin, addressbook.bnl.gov;
and it fetches information for other models from NSLS-II's AD proxy server round-robin, ldapproxy.nsls2.bnl.gov, which proxies to addressbook. These could/should probably be merged to fetch from a single source of truth, presumably directly from addressbook.
Some changes to ActiveDirectory models might be required, such as an adapter between ActiveDirectoryUser and LDAPUserResponse.
Changes could potentially be upstreamed to N2snUserTools.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Nsls2Api and the ActiveDirectoryUser and LDAPUserResponse models to understand which models use each AD endpoint. Compare the possible changes with N2snUserTools; done means the relevant models fetch from one agreed source and remain compatible with the API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100