NSLS2 / NSLS2/nsls2api

Let's revisit this approach to potentially leverage Enum and a loop.

Open
#230 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
13
Avg merge
1h 17m
Merged PRs (30d)
1

Description

Let's revisit this approach in a future PR, where we could leverage Enum and a loop.

I'll move this comment to a GH issue momentarily.

Originally posted by @padraic-shafer in https://github.com/NSLS2/nsls2api/pull/212#discussion_r2722864334

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the original discussion in PR 212, especially the comment linked in this issue, to understand the existing approach and the proposed use of Enum and a loop. The issue does not identify files, tests, or acceptance criteria, so clarify the intended refactor and definition of done before coding.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.