NSLS2 / NSLS2/cditools

Fix Pyright type errors in merlin and trigger_mixins

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
4
PR merge metrics
No merged PRs in 30d

Description

There are a few type errors raised by pyright that block its use in CI testing. Fix and re-enable pyright in .pre-commit-config.yml

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running Pyright against the merlin and trigger_mixins code to identify the reported type errors. Read .pre-commit-config.yml to see how Pyright is currently disabled. Done means the type errors are fixed and Pyright is re-enabled for CI testing.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.