set-wallpaper will certainly fail for KDE and other desktops
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 3
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
If I am understanding the operation of set-wallpaper correctly, you rely on the existance of /usr/bin/gsettings as the indicator of the choice of gnome as the desktop environment. In fact, it only indicates that gnome has been installed on the computer, which is often true even if another desktop is in use.
A better test would be against something like $XDG_CURRENT_DESKTOP, which would resolve the desktop actually in use.
Will work on a PR that works for KDE....
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the set-wallpaper entry point and inspect how the presence of /usr/bin/gsettings selects the desktop. Check the available XDG_CURRENT_DESKTOP value on KDE and verify that set-wallpaper uses the active desktop choice rather than installed software; done means the command works on KDE and does not misidentify GNOME.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- cli, desktop-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100