NETWAYS / NETWAYS/postfix-logstash-pipeline
Improve checking for IP address or domain name
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Thanks @RincewindsHat for pointing that out. There are valid domain names that start with a digit. To be honest, I don't know if a hostname may start with a digit, too according to RFC. But since it's possible, we have a domain name in server.address and client.address we should make sure to have a more robust check in filter-70-client.conf and filter-70-server.conf.
To be honest, I consider host- and domainnames starting with a digit as fairly exotic. So I think it's important to fix that but not an immediate must to start a fix right now.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the address checks in filter-70-client.conf and filter-70-server.conf, starting with how server.address and client.address are currently recognized. Compare the checks with valid domain and hostname cases that begin with a digit; done means both filters handle those cases without breaking existing address parsing.
Written by the indexing model from the issue text.
Assessment
- Domain
- data-engineering
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100