NETWAYS / NETWAYS/postfix-logstash-pipeline

Improve performance with `else if`

Open
#32 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The current filters have a lot of if checks. But when we look closely we see that most events can only match one filter in a file and not many. So after the first match we can skip testing for more hits. This skipping can be achieved by changing if into else if.

So check all filter files and replace if with else if where appropriate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inventorying the repository's filter files and tracing how events are matched in each one. Identify checks that are mutually exclusive, update only those branches to short-circuit, and verify that parsing behavior remains unchanged across the pipeline.

Written by the indexing model from the issue text.

Assessment

Domain
data-engineering
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.