NETWAYS / NETWAYS/go-check

Allow state overview on non-OK states

Open
#167 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
15
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Right now - unless i am doing something wrong - its not possible for me to have that state overview

[OK] - states: ok=2
\_ [OK] System Board 1 Ambient Temp --- 0.7.1.14 is 20°C
\_ [OK] System Board 1 Test Temp is 250°C
|temp=20C;500;600 temp=250C;500;600

Now, when the overall state is critical because one of the subchecks is critical, the first line shows the worst subchecks result:

[CRITICAL] - System Board 1 Test Temp is 250°C
\_ [OK] System Board 1 Ambient Temp --- 0.7.1.14 is 20°C
\_ [CRITICAL] System Board 1 Test Temp is 250°C
|temp=20C;50;60 temp=250C;50;60

I think its a valid idea to do it like its currently is, but an optional feature to change it to my expected behaviour - showing states: critical=1, ok=1 - would be a good idea.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named; first locate the code that aggregates subcheck states and renders the overall status line, then inspect existing tests for state output. Add coverage showing an overall critical result can report both critical and OK counts while preserving the current output by default.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability-sre
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.