NETWAYS / NETWAYS/alertmanager-icinga-bridge

[Feature]: Validate custom severity mapping instead of truncation

Open Beginner friendly
#41 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
0
Forks
3
Avg merge
3d 14h
Merged PRs (30d)
4

Description

Describe the feature request

custom severity levels are processed but any errors (non-intergers or values outside of the valid range) are silently interpreted as UNKNOWN/3. IMO it would make more sense to raise an error to inform the user about potential problems instead of silently correcting any misconfiguration.

i can provide an MR with a potential solution

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read internal/config/config.go at the linked line where custom severity values are interpreted. Trace how invalid non-integer and out-of-range values are handled, then make completion mean that misconfiguration produces an error instead of silently becoming UNKNOWN/3.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.