NCAS-CMS / NCAS-CMS/cf-python

Manual UMRead `make` recompile for PP file recognition

Open
#91 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

installation um/pp
Dominant language
Python
Stars
150
Forks
23
Avg merge
1d 11h
Merged PRs (30d)
2

Description

From a clean installation, at least under certain conditions, it appears e.g. as evidenced in point no. 1 of https://github.com/NCAS-CMS/cf-python/pull/87#issuecomment-645367474 that unless make is run for the UMRead library:

$ cd cf/umread_lib/c-lib
$ make

that PP files cannot be read in, e.g. as demonstrated in the test suite:

File "/home/runner/work/cf-python/cf-python/cf/read_write/read.py", line 928, in file_type
raise IOError("Can't determine format of file {}".format(filename))
    OSError: Can't determine format of file <filename>.pp

So we may need to add some steps to the setup.py to create the correct setup for PP processing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with setup.py and the UMRead library under cf/umread_lib/c-lib; run make there from a clean installation and reproduce the PP-file failure in the test suite. Compare the setup path with the manual build, then verify that PP files are recognized without manually running make.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, python
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.