NCAS-CMS / NCAS-CMS/cf-python

CI: fix flakiness of some precision-based testing

Open
#679 0 comments 0 reactions 1 assignee View on GitHub

@sadielbartholomew is already working on this.

Since Jun 30, 2023.

CI GitHub Actions testing
Dominant language
Python
Stars
150
Forks
23
Avg merge
1d 11h
Merged PRs (30d)
2

Description

Some tests which pass locally fail on some (and possibly all in some cases) of the CI job runs corresponding to the full test suite running workflow. They therefore seem to be 'flaky' tests.

Most if not all of these tests involve precision equality testing, for example isclose with given atol and rtol and therefore floating point rounding or tolerance variations are likely the reason for the variation in result on different environments.

See also the following comments, for further context:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.