NCAS-CMS / NCAS-CMS/cf-python

LAMA to Dask: reinstate string-like data equality test

Open
#298 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dask
Dominant language
Python
Stars
150
Forks
23
Avg merge
1d 11h
Merged PRs (30d)
2

Description

(For the lama-to-dask branch RE the overarching #182 task,) once NCAS-CMS/cfdm#172 is resolved, the following assertion can be reinstated in the test_Data_equals test:

https://github.com/NCAS-CMS/cf-python/blob/629368b75d9eecc8300d65064dae20e2dc25a949/cf/test/test_Data.py#L317-L320

Presently it is commented out as shown because it is failing on lack of appropriate behaviour in cfdm.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/test_Data.py lines 317-320 and inspect the test_Data_equals test. Check whether NCAS-CMS/cfdm#172 is resolved before making a change; done means the commented assertion is reinstated and the test passes on the lama-to-dask branch.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.