Refactor for argmax and new method argmin
Open
Nobody has claimed this yet.
API review (4.0.0)
enhancement
- Dominant language
- Python
- Stars
- 150
- Forks
- 23
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 2
Description
We currently support an argmax method (see e.g. here) on the Data and Field classes, but not an equivalent argmin.
We've noted to add in argmin in time for the next minor release, but to do so by refactoring somewhat to create a common base for these methods (and potentially other similar ones).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing argmax implementations on the Data and Field classes, using the linked Data.argmax documentation as the starting point. The work is done when the shared method structure supports both argmax and the new argmin method consistently on those classes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100