NCAS-CMS / NCAS-CMS/cf-plot

lfric_initial (used in testing) is an invalid unstructured grid file

Open
#124 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

v35plus
Dominant language
Python
Stars
21
Forks
11
Avg merge
7h 11m
Merged PRs (30d)
1

Description

The file needs to be replaced with a valid file (e.g. https://github.com/NCAS-CMS/cf-python/blob/main/cf/test/ugrid_global_2.nc), and the tests rewritten without the explicit binding of the grid variables to the plotting keywords. We should also ensure that cf-python does not raise any read warnings.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the lfric_initial test data and the tests that bind its grid variables to plotting keywords. Compare it with cf/test/ugrid_global_2.nc, replace the invalid file, and rewrite those tests so cf-python reads it without warnings and the plotting checks still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.