Add assertions to policy test
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10
- Forks
- 10
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 13
Description
@K20shores this looks like a bug to me. How could our previous GPU test passes without this copy?
Originally posted by @sjsprecious in #967
See the comments on this PR. As @DWesl suggested, we could at minimum check for mass-balance and non-negative concentrations
Acceptance critieria
- Concentrations in test random system are copied back from GPUs
- Test random system adds assertions
Ideas
- check mass balance
- check for negative concentrations
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/unit/process/test_process_set_policy.hpp at the test random system around line 190. Check how concentrations are copied back from GPUs, then add assertions for mass balance and non-negative concentrations. Done means the random-system test verifies the copied-back concentrations and catches the described GPU-copy bug.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100