NCAR / NCAR/fire_behavior

Remove internal FindESMF.cmake file, use FindESMF.cmake file installed with ESMF

Open
#17 0 comments 0 reactions 1 assignee View on GitHub

@danrosen25 is already working on this.

Since Sep 25, 2025.

Dominant language
Fortran
Stars
11
Forks
17
Avg merge
21h 12m
Merged PRs (30d)
1

Description

EMC is suggesting that we remove the internal FindESMF.cmake file and use the FindESMF.cmake file included with an ESMF installation
https://github.com/NOAA-EMC/fire_behavior/pull/2

This can be done by providing the location of the esmf.mk file, which points to the location of the ESMF cmake modules using the ESMF_CMAKEDIR variable. This variable's value can be prepended to the CMAKE_MODULE_PATH list. EMC is specially using ESMF_ROOT to find the FindESMF.cmake file. The advantage of this is that the FindESMF.cmake file does not have to be maintained by the CFBM team.

Suggested by @DusanJovic-NOAA

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.