SGSCloud_Rad* routines not compatible with fewer radiation levels than (standard) model levels
Open
@dustinswales is already working on this.
Since Aug 19, 2022.
- Dominant language
- Fortran
- Stars
- 78
- Forks
- 170
- PR merge metrics
- No merged PRs in 30d
Description
In physics/module_SGSCloud_RadPre.F90, clouds1 is updated from cldfra_bl looping over horizontal_loop_extent and vertical_dimension. clouds1 however has dimensions horizontal_loop_extent and adjusted_vertical_layer_dimension_for_radiation - or better to say should have, because it is wrong in physics/module_SGSCloud_RadPre.meta.
There are possibly other such cases. To do:
- check all variables for their correct vertical dimension
- pass in
adjusted_vertical_layer_dimension_for_radiationin addition tovertical_dimension - loop over the correct vertical dimension as required
We need to do this for both module_SGSCloud_RadPre and module_SGSCloud_RadPost.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.