NCAR / NCAR/ccpp-framework

Simplify testing framework

Open
#741 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement post-capgen-unification question
Dominant language
Python
Stars
25
Forks
67
Avg merge
3d 8h
Merged PRs (30d)
2

Description

Description

For capgen, we build and run the tests with CMake, and if it passes then we run another Python-based test on the output. That seems redundant and unnecessarily complicated to me.

Welcoming feedback on whether this is a good idea or not.

Does the Python framework test aspects of the API that the CMake tests don't test? Or are the CMake ctest-based tests comprehensive enough to do away with the Python-based tests?

What we should avoid is testing frameworks that are redundant. For example, every time a variable changes in the output list, one has to fix the Fortran test code and the Python test code.

Solution

Consolidate the testing frameworks as appropriate so that there is no redundancy, unless absolutely needed.

Alternatives (optional)

Do nothing

Related to (optional)

https://github.com/NCAR/ccpp-framework/issues/737

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the CMake/ctest-based tests with the Python-based test that runs on the output, including the Fortran test code they may duplicate. Review related issue #737 for context and identify which API aspects each framework covers. Done means a clear consolidation decision and removal of redundant test paths without losing coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, fortran, python
Domain
build-system, testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.