NCAR / NCAR/ccpp-framework

Impose hard limit on standard name length

Open
#711 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
25
Forks
67
Avg merge
3d 8h
Merged PRs (30d)
2

Description

Description

As part of the diagnostic name implementation in https://github.com/NCAR/ccpp-framework/pull/695, @climbfuji noted that it might be good to have a length limit for standard names (length limit for diagnostic names is 256 due to NetCDF limitations).

Proposed length limit: 256 (though there are arguments for a smaller limit).

Once this is implemented, the code in var_props.py to trim the standard name to 256 characters can be removed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the standard-name handling and the trimming code in var_props.py, then compare it with the diagnostic-name length handling introduced by pull request 695. Implement the agreed 256-character limit, remove the obsolete trimming, and verify the existing standard-name behavior and tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.