NCAR / NCAR/ccpp-framework

DEBUG Mode improvements

Open
#658 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
25
Forks
67
Avg merge
3d 8h
Merged PRs (30d)
2

Description

Description

Existing DEBUG checks test the extent of all host-model allocatable variables within the Suite Cap. However, these host-model allocatable variables are passed through the Suite Caps as assumed-shape, and their extents are only known by the Host and the Scheme. In the CCPP, any differences between the Host and Scheme variables dimensions would be caught during the metadata comparison step, not at runtime.
So having these checks in the Suite Cap is unnecessary.

Solution

Move these tests to the Host Cap, where any allocation mismatch between the Host and Scheme could be caught at runtime.
For allocatable Scheme variables, we still need to test the variable extents within the Suite Cap, where the allocation occurs.

More discussion can be found in #652

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the discussion in issue #652 first, then trace the existing DEBUG checks in the Suite Cap and the corresponding Host Cap. Verify where host-model and Scheme allocatable variables are allocated and compared. Done means host-model extent checks run in the Host Cap while Scheme allocation extent checks remain in the Suite Cap.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.