NCAR / NCAR/ccpp-framework

New checks/update getter for molar_mass in constituents object

Open
#620 0 comments 0 reactions 1 assignee View on GitHub

@peverwhee is already working on this.

Since Dec 24, 2024.

enhancement
Dominant language
Python
Stars
25
Forks
67
Avg merge
3d 8h
Merged PRs (30d)
2

Description

Description

It would be nice to have:

  1. A check of whether molar_mass is set to 0 (which would return an error message) since molar_mass is often used as a denominator in unit conversions
  2. Return an errmsg from the getter if the molar_mass = kphys_unassigned (probably no error code, but just would be nice to have a clean way for the host to know if molar mass has been assigned)

Solution

  1. Add check to instantiate() that returns an errmsg (and probably and errcode) if molar mass is being set to 0
  2. Modify ccp_molar_mass to return a message when

Alternatives (optional)

If applicable, add a description of any alternative solutions or features you've considered.

Related to (optional)

Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.