Remove default "dry" mixing ratio from constituent object "instantiate"
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 25
- Forks
- 67
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 2
Description
Description
The standard name rules specify that you always need to specify what the mixing ratio is wrt to:
By default, mixing_ratio refers to mass mixing ratios. The long name should explicitly specify that it refers to the mass mixing ratio. Mass mixing ratios should contain information regarding with respect to what quantity they are defined, and options are wrt_dry_air, wrt_moist_air, or wrt_moist_air_and_condensed_water, where moist_air refers to dry air plus vapor and moist_air_and_condensed_water refers to dry air plus vapor and hydrometeors. Use of specific_humidity should be avoided as there is no consensus on whether it refers to mixing_ratio_of_water_vapor_wrt_moist_air or mixing_ratio_of_water_vapor_wrt_moist_air_and_condensed_water. total_water can be used to designate water in every form, i.e. water vapor plus condensed water.
The logic in the constituents object currently defaults to "dry" if nothing is specified, but that should be removed and it should produce an error if you don't specify.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Python constituents object logic that applies the default mixing ratio. Trace the path used when no mixing-ratio reference is specified, then update the behavior so it raises an error instead of defaulting to "dry" and verify the relevant tests cover the missing-specification case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100