NCAR / NCAR/ccpp-framework

Implement new constituent property/field to track "above the top of model" values

Open
#573 0 comments 0 reactions 1 assignee View on GitHub

@peverwhee is already working on this.

Since Jun 21, 2024.

enhancement
Dominant language
Python
Stars
25
Forks
67
Avg merge
3d 8h
Merged PRs (30d)
2

Description

Description

At least one CAM chemistry package (TUV-X) requires constituent values above the top of the model. We will need a mechanism for optionally allocating and keeping track of these values for the constituents that need this information.

Solution

  1. Implement new logical metadata property above_model_top that, when true, will trigger relevant allocation/setting of below
  2. Implement a new constituent property above_model_top_index that will return -1 if the constituent doesn't need this information and otherwise the index of the array in (3) below
  3. Implement a new field in the ccpp_model_constituents_t object above_model_top_array that will be an allocatable array of 2 dimensions (dimension 1 will be allocated to the number of columns, dimension 2 will be allocated to the number of constituents that require this field). This field will also be added to ccpp_constituent_prop_mod.meta with standard name ccpp_constiutent_above_model_top_values

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.