NCAR / NCAR/MechanismConfiguration
Add `photolysis_calculator:` configuration
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1
- Forks
- 3
- Avg merge
- 9h 30m
- Merged PRs (30d)
- 4
Description
See #268. Add PhotolysisCalculator struct to mechanism_configuration:: and parsing logic to the v1 parser.
Acceptance criteria
std::optional<PhotolysisCalculator> photolysis_calculatoradded toMechanism- likely only needs to provide a filepath
- we can check that the filepath exists
- however for tuv, it's configuration file might need to be specified as a relative path, which means the existance check might not be helpful or feasible
- this would also support cloud j, which we might be adding support for
Ideas
- If we do a path existence check, it belongs in
validate(), not `parse()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the context in #268 and locating the Mechanism type in the mechanism_configuration namespace, then trace the v1 parser and validate() flow. Add the optional PhotolysisCalculator configuration with its filepath and parsing support, resolving whether validation should check path existence; done means the v1 configuration parses and the acceptance criteria are covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100