NCAR / NCAR/DART

Compare to correct in location_mods

Open
#971 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

performance
Dominant language
Fortran
Stars
263
Forks
182
Avg merge
11d 12h
Merged PRs (30d)
7

Description

These arrays are pretty big to allocate, and are only used if you are doing COMPARE_TO_CORRECT

https://github.com/NCAR/DART/blob/59b75b716f761b447382bb0fe59044bbb9c2275d/assimilation_code/location/threed_sphere/location_mod.f90#L1442-L1444

Originally posted by @hkershaw-brown in #910

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading assimilation_code/location/threed_sphere/location_mod.f90 around lines 1442-1444 and trace the arrays used by COMPARE_TO_CORRECT. Confirm when those arrays are needed and how their allocation is currently reached. Done means the large arrays are not allocated for other modes while COMPARE_TO_CORRECT still works correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
hpc
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.