bug in bnrh_distribution_mod.f90
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 263
- Forks
- 182
- Avg merge
- 11d 12h
- Merged PRs (30d)
- 7
Description
User running r8 = r4,
getting the message:
final q 0.9999999
final q 0.9999999
final q 0.9999999
....
Definite bug that this "temporary" code is calling stop rather then the error_handler (mpi programs only some of the tasks are stopped)
https://github.com/NCAR/DART/blob/55c4b9669f9b65d4b9c315cd5d0f3501fa2b3d22/assimilation_code/modules/assimilation/bnrh_distribution_mod.f90#L509-L513
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in assimilation_code/modules/assimilation/bnrh_distribution_mod.f90 at lines 509-513 and inspect how this temporary code reports errors elsewhere in the module. Replace the MPI-inappropriate stopping behavior with the established error_handler path, then verify that the repeated final q output no longer leaves MPI tasks inconsistently stopped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100