Note on obstype terminology for quantity
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 263
- Forks
- 182
- Avg merge
- 11d 12h
- Merged PRs (30d)
- 7
Description
There are places in the code where obstype is used, but the variable/argument is referring to qty
We've updated this in the template model, and when we refactor model_mods, but there is still a lot of 'obstype' hanging around in model_mods and fwd ops. Particularly for people using the QCEFF and debugging their runs, the loose naming type (for qty) adds an unneeded overhead to reading the code.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching model_mods and fwd ops for remaining uses of “obstype,” comparing them with the updated template model and model_mods refactor. Review QCEFF-related usage to distinguish quantity arguments from actual observation types. Done means the terminology is consistent wherever the variable or argument refers to qty.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100