calling transform intent(in)== intent(out)
Open
Nobody has claimed this yet.
Critical
fortran standards
QCEFF
- Dominant language
- Fortran
- Stars
- 263
- Forks
- 182
- Avg merge
- 11d 12h
- Merged PRs (30d)
- 7
Description
this is still dangerous since you have the same input for intent(in) and intent(out), but the original code does that so yippee ki yay I guess.
Originally posted by @hkershaw-brown in https://github.com/NCAR/DART/pull/794#discussion_r1909439384
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading assimilation_code/modules/assimilation/probit_transform_mod.f90 around lines 596-601 and the linked discussion from pull request #794. Determine the intended handling when the same value is used for intent(in) and intent(out), then verify that the resulting behavior is no longer dangerous.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100