probit transform integer return code?
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 263
- Forks
- 182
- Avg merge
- 11d 12h
- Merged PRs (30d)
- 7
Description
why use an integer return code? For different types of failures?
The oks are logicals.
logical, allocatable :: obs_probit_trans_ok(:), state_probit_trans_ok(:)
Originally posted by @hkershaw-brown in https://github.com/NCAR/DART/pull/794#discussion_r1909405233
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the probit transform implementation and reviewing the return-code handling alongside obs_probit_trans_ok and state_probit_trans_ok. The issue does not name a file or test, so first establish whether integer codes and logical flags represent different failure cases. Done means the return convention and failure semantics are explicitly decided and consistently reflected in the implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100