possible bug: MITgcm_ocean potential temperature
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 263
- Forks
- 182
- Avg merge
- 11d 12h
- Merged PRs (30d)
- 7
Description
The mitgcm_ocean model_mod interpolates qty_temperature directly (no conversion from potential temp)
https://github.com/NCAR/DART/blob/2d5882c3084dcdfd2f57a01b505c7fe039689cba/models/MITgcm_ocean/model_mod.f90#L639
The model appears to use potential temperature in the state:
note also potential salinity vs salinity.
Possibly this is just a naming issue with the model state, but I figured I would note this rather than the comment getting buried in
https://github.com/NCAR/DART/issues/773
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect models/MITgcm_ocean/model_mod.f90 around line 639, then compare the temperature and salinity state settings in work/input.nml and trans_mitdart_mod.f90 around lines 382-383. Determine whether the state uses potential or ordinary quantities; done means the interpolation and naming consistently match that choice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100