NCAR / NCAR/DART

get_dist for VERTISSURFACE

Open
#757 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Fortran
Stars
263
Forks
182
Avg merge
11d 12h
Merged PRs (30d)
7

Description

Moved from #756

location_mod get_dist "! Vert distance can only be done for like vertical locations units"
why can you not calculate vertical distance between two points one with VERTISSURFACE(m) and one with VERTISHEIGHT(m)?

https://github.com/NCAR/DART/blob/e2188646b97573f198c66f7ea63482ebc34afa11/assimilation_code/location/threed_sphere/location_mod.f90#L507-L509

Originally posted by @hkershaw-brown in https://github.com/NCAR/DART/issues/756#issuecomment-2435532825

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read assimilation_code/location/threed_sphere/location_mod.f90 around lines 507-509 and trace get_dist's handling of VERTISSURFACE and VERTISHEIGHT. Review the linked issue discussion to establish the intended mixed-unit behavior; done means either supporting the requested distance calculation or documenting a clear rationale for retaining the restriction.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.