models that reject "obs" in model interpolate for being two high or two low - problem for column obs_defs
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 263
- Forks
- 182
- Avg merge
- 11d 12h
- Merged PRs (30d)
- 7
Description
There are several model_mods that have model_interpolate calls that will fail for locations above or below a given location. For forward operators where a whole column, or a surface value is needed this causes the forward operator to fail. RTTOV forward operators are where people are hitting this but I believe it applies to any forward operator (obs_def) that requires a full column or some surface value of a qty.
model_interpolate does not get the observation as input. A call to model_interpolate requests the value of a quantity at a location. There are several (3-4 noted below but maybe more) where the model_mod::model_interpolate is treating model_interpolate as a way to reject observations, rather than simply providing the value of the quantity at the location.
-
wrf https://github.com/NCAR/DART/issues/366 rttov obs_def is using model_interpolate to count the levels so one-off.
-
cam se/fv discarding_high_obs so radiance fwd operators will fail (rttov needs whole column) https://github.com/NCAR/DART/issues/438
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with model_mod.f90 in mpas_atm, especially lines 1268-1270, and trace how RTTOV obs_def uses model_interpolate. Then inspect the corresponding WRF and CAM model_mod paths referenced by issues #366 and #438. Done means affected interpolation paths support valid full-column or surface requests without rejecting locations solely for being above or below the model range.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100