NCAR / NCAR/DART

bug: CLM water/snow/radiation/energy balance checks turned off when DA turned on

Open
#671 3 comments 0 reactions 1 assignee View on GitHub

@braczka is already working on this.

Since May 2, 2024.

CLM SourceMods
Dominant language
Fortran
Stars
263
Forks
182
Avg merge
11d 12h
Merged PRs (30d)
7

Description

🐛

Describe the bug
  1. List the steps someone needs to take to reproduce the bug.
    Run CLM-DART with version cesm2.2.0 versions or later. For example, run CLM-DART tutorial.
    Run CLM-DART with DA enabled (i.e. DATA_ASSIMILATION_LAND=TRUE)

  2. What was the expected outcome?

    The balance checks within CLM source code ~/src/biogeophys/BalanceCheckMod.F90 should be enabled after skipping a time
    step or two after DA analysis step, because the skip_step = 2.

    We currently do not have DART cesm2_2 SourceMods that override this functionality because it looked like the original CLM
    code was designed to be run interactively with DART without specific SourceMods.

  3. What actually happened?

    The balance checks are never enabled, because DAnstep = 0, for the entirety of the simulation, thus failure of balance checks is never enabled because the following if statement to throw mass balance error is never true, for example:

if ((errh2o_max_val > error_thresh) .and. (DAnstep > skip_steps))

When DA is turned off (running ensemble free run), the DAnstep is updated, and the checks are enabled.

Error Message

None.

Which model(s) are you working with?

ctsm-release-cesm2.2.03

Version of DART

Which version of DART are you using?

v11.4.0

Have you modified the DART code?

No

Build information

Please describe:

  1. NSF NCAR supercomputer Derecho with intel compiler

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.