NCAR / NCAR/DART

bug: obs_seq_coverage does not recognize all QC metadata generated by obs converters

Open
#428 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Fortran
Stars
263
Forks
182
Avg merge
11d 12h
Merged PRs (30d)
7

Description

Describe the bug
  1. Create or find an obs_seq file which has a platform QC metadata which is not found in the hard-coded list in subroutine find_our_copies (Quality Control, NCEP QC index, DART quality control) (see attached; remove the TXT, then tar -z -x -f).
  2. Feed it to obs_seq_coverage.
  3. Expect a file with a list of locations where repeated obs are taken.
  4. Program fails (see attached).
Error Message

find_qc_indices metadata:source Quality Control copyindex not found

Which model(s) are you working with? WACCM-X, but that's not relevant
Version of DART

Which version of DART are you using? Manhattan, circa 2022-10 and older

Have you modified the DART code?

No
A short term fix is to add "COSMIC QC" to the series of "if" statements.
But a more general possibility is to define a namelist variable that contains a list of permissible QC metadata.
Then any user can provide new values without debugging or asking us, plus modifying the code and recompiling.
This is an issue for other programs too, but I have not identified all of them yet.

Build information

Please describe:

  1. The machine you are running on (e.g. windows laptop, NCAR supercomputer Cheyenne). Any
  2. The compiler you are using (e.g. gnu, intel). Any
    obs_seq_coverage_io.tgz.TXT

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the obs_seq_coverage entry point and inspect the find_our_copies and find_qc_indices subroutines, especially their handling of QC metadata. Reproduce the failure with the attached obs_seq_coverage_io archive and the reported COSMIC QC value. Done means obs_seq_coverage accepts QC metadata generated by obs converters and produces the repeated-observation location list without failing.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.