State IO

Notes for state IO

• read_variables is public and is used by mpas_atm/update_bc.f90

• out of date comments in state_vector_iod_mod.f90 (e.g reference to construct_file_name_in() which no longer exists)

  • read_model_time directly from model_mod rather than assim_model_mod
  • out of date comments on "dart format read"

• io_filenames_mod has a bunch of references to diagnostic files which no longer exist

• io_filanmes_mod is doing a bunch of netcdf variable checking

  • state_structure_mod also has a mix of netcdf file info vs. state info

• stages_to_write is in state_vector_io_mod - more sense to have this info in io_fileaames_mod?

• see #283 for round robin assumption

• write_augmented_state - why the restriction on ! if there is only one timestep in your input file insert the mean and sd if requested

• NO COPY BACK variables vs. per-ensemble static data.

• perturb_single_instance with NO_COPY_BACK (see #276)

• perfect_model_obs - should this have single_file_in/out namelist options?

• Marlee is working on the state stucture (see #106)

• clamp_or_fail is in some model_mods, but not used at all https://github.com/NCAR/DART/issues/404#issuecomment-1894552566

• diagnostic structure in the code but not used at all half used see https://github.com/NCAR/DART/issues/359#issuecomment-2293486652? https://github.com/NCAR/DART/blob/924182f29ce23f2a4e4c53aa57cc7d00fdccf374/assimilation_code/modules/io/state_structure_mod.f90#L131-L135

• assuming unlimited dimension is by domain

• assuming only 1 unlimited dimension

• assuming 1d,2d,or 3d variables