NCAR / NCAR/DART

obs_converter notes: obs_err mods

Open
#302 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug duplicated code obs_converters
Dominant language
Fortran
Stars
263
Forks
182
Avg merge
11d 12h
Merged PRs (30d)
7

Description

obs_error directory

  1. Duplicate file meteor_mod.f90:
    obs_converters/NCEP/netcdf/meteor_mod.f90
    obs_converters/MADIS/meteor_mod.f90

  2. obs_converters/obs_error directory:

The readme

IMPORTANT:
Each file should have the same module name; i.e. the source
file names will differ but the module name inside the file
must be the same across all modules in this directory.

All the subroutines must also have the same names and
calling sequence. They must return appropriate values 
for each observation type that is required.  
If errors for a new observation type is added, it should
be added to all the files in this directory.

ncep_obs_err_mod.f90 has more public routines than ecmwf_obs_err_mod.f90

public :: metar_pres_error,              &
              metar_rel_hum_error,           &
              metar_temp_error,              &
              metar_wind_error

dewpoint_obs_err_mod.f90 is different to ncep/ecmwf_obs_err_mod.f90

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the README in obs_converters/obs_error, then compare ncep_obs_err_mod.f90, ecmwf_obs_err_mod.f90, dewpoint_obs_err_mod.f90, and the two meteor_mod.f90 paths listed in the issue. Identify the module, public-routine, and calling-sequence differences; completion criteria are not specified beyond bringing the files into the README's stated consistency.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.