Bug?: direct_netcdf_mod.f90 assumes round robin distribution for ensemble
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 263
- Forks
- 182
- Avg merge
- 11d 12h
- Merged PRs (30d)
- 7
Description
direct_netcdf_io.f90:
2933 !=================================================
2934 ! Routines for distributing data round-robbin
2935 !=================================================
!> This code has multiple places where round-robin layout of state onto task is assumed.
!> These are in the section labelled:
!> ! Routines that are making the assumption that the ensemble
!> ! distribution is round-robin (distribution type 1)
Note distribution type 1 is not round robin, it is simple layout. So if you set your ensemble_manager_nml::layout=1 (simple) I think you may get incorrect info read in/written out. edit: Nope, see note below on layout vs. distribution
I'm missing why perfect_model_obs has layout 1 (simple) for fwd op and qc, but these handles are not involved in the netcdf state read/write
https://github.com/NCAR/DART/blob/62ecfa2a2b4c7de55f98f434de49e076060fd82c/assimilation_code/programs/perfect_model_obs/perfect_model_obs.f90#L454
will confirm with test case for state IO
Affects filter, perfect_model_obs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the routines around line 2933 in direct_netcdf_io.f90 and compare their distribution assumptions with the simple layout. Then inspect perfect_model_obs.f90 around line 454 and confirm the behavior with a state I/O test case. Done means verifying correct state read/write behavior for filter and perfect_model_obs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100