MITgcm salinity units
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 263
- Forks
- 182
- Avg merge
- 11d 12h
- Merged PRs (30d)
- 7
Description
Discussion today at standup that there are converters that we do not have in DART (collaborators - I am not sure who) that output PSU (g/g). This is a pain, but so as to not break their code, namelist option for ROMS_rutgers & MITgcm to have model_interpolate give MSU or PSU for salinity.
Punting on MITgcm ocean since it has a converter in the model directory: https://github.com/NCAR/DART/blob/main/models/MITgcm_ocean/create_ocean_obs.f90
and with observation converter in this model module: https://github.com/NCAR/DART/blob/main/models/MITgcm_ocean/dart_MITocean_mod.f90
seems to be hfradar. Will move this MITgcm units to another issue
Originally posted by @hkershaw-brown in #1003
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First confirm whether this issue still covers MITgcm ocean work, since the body says that work will move to another issue. If it remains in scope, read models/MITgcm_ocean/create_ocean_obs.f90 and models/MITgcm_ocean/dart_MITocean_mod.f90, then trace the model_interpolate namelist handling. Done should be an agreed MSU/PSU behavior for the applicable converter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100