NASA-IMPACT / NASA-IMPACT/veda-docs
Remove hvplot workaround in downsample_zarr notebook
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 10
- Forks
- 16
- Avg merge
- 2d 31m
- Merged PRs (30d)
- 4
Description
Based off the report in https://github.com/NASA-IMPACT/veda-docs/pull/119#issue-2136845617 there was a bug uncovered in hvplot > 0.8.4: https://github.com/holoviz/hvplot/issues/1329.
For now the downsample_zarr notebook downgrades hvplot to work around the bug. And in #139 a different workaround is introduced of just passing a cartopy crs object directly.
But once the bug is resolved and a new version of hvplot is released and available in the pangeo image, we should be able to remove the workaround.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the downsample_zarr notebook and check the current hvplot version available in the pangeo image, along with the workaround described in the issue and #139. Once the hvplot bug is resolved and the fixed version is available, remove the downgrade workaround and verify that the notebook still runs correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter-notebook
- Domain
- documentation
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100