NASA-IMPACT / NASA-IMPACT/akd-core

PSI Curation: Revision summary conflicts with unchanged QA flags

Open
#568 0 comments 0 reactions 3 assignees View on GitHub

@sanzog03 is already working on this.

Since Sep 18, 2026.

bug
Dominant language
Jupyter Notebook
Stars
4
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

Summary

During a PSI curation test, the Revision Agent reported that requested changes were added to the investigation package, but the QA panel continued to report the revised information as missing.

This makes it unclear whether the Revision Agent failed to save the changes or whether the QA results were not recalculated after the package was revised.

Actual result

The Revision Agent stated that:

  • Publications and DOI values were added.
  • The analyzed-results file was marked for combined Earth/Reduced Gravity handling.
  • The unresolved QA flags were updated.

However, the QA panel continued to show 14 flags, including:

  • doi — DOI not found
  • publications — no publications found
  • sorting — one Raw/Analyzed Data file has no gravity subcategory

The interface also continued to label the investigation package as “complete” while these warnings remained unresolved.

User impact

The curator cannot determine whether the requested corrections were actually saved. This creates a risk that a curator could approve or export a package containing missing or stale information.

The “complete” status may also give users the impression that the package is ready for publication, even though it still requires curator review.

Supporting evidence

Image

Figure 1. I request for the DOI's and Publications to be added, and the agent tells me "Publications and their DOIs were added to metadata" and "unresolved QA flags are updated accordingly."

Image

Figure 2. The QA flags state that the DOI and Publications were not found and should be added by the curator, after the revision agent told me it was found and added to the metadata

Image

Figure 3. When I open up the JSON package, the information for the DOIs/Publications are in fact included, indicating that the QA flags are not being updated

Image

Figure 4. On the left hand side of the curation site, it indicates this chat as "complete" although there are QA flags still present and I didn't approve it yet. Maybe changing this wording would be best (see below)

Suggested areas to investigate

  • Confirm that revision changes are written to the stored package.
  • Confirm that QA is rerun after every successful revision.
  • Confirm that the QA panel retrieves the newest QA results rather than cached results.
  • Confirm that the revision summary is generated from changes that were successfully saved.
  • Review whether “complete” should be replaced with “generated—curator review required” when unresolved warnings remain.
Steps to reproduce the behavior

Environment

  • Application: PSI Curation Pipeline
  • URL: https://psi.akd.odsi.io/curation
  • Date tested: September 15, 2026
  • Investigation: PSI-186, Coupled Growth in Hypermonotectics
  • Agents involved: Revision Agent and Synthesis Agent
  • User roles: Admin and curator

Steps to reproduce

  1. Start a curation run for PSI-186, “Coupled Growth in Hypermonotectics.”

  2. Complete the Sourcing, Sorting, and Synthesis stages.

  3. Review the initial QA results. The package reported that DOI, publication, and analyzed-data gravity-subcategory information was missing.

  4. Provide the following sources:

  5. Request that the Revision Agent:

    • Add the supported publications and DOI values.
    • Categorize CGH_processed_results.xlsx as Analyzed Data / Earth and Reduced Gravity.
  6. Wait for the revised package to be returned.

  7. Compare the Revision Agent’s completion message with the displayed QA flags.

Expected Behavior

Expected result

The requested changes should be written to the revised package. The QA process should then run against the updated package.

If the DOI, publications, and gravity subcategory are successfully added, their corresponding QA flags should be removed. Any genuinely unresolved QA flags should remain.

The interface should clearly distinguish between:

  • Pipeline processing completed
  • Package awaiting curator review
  • Package approved or ready for export
Relevant log output

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.