NASA-AMMOS / NASA-AMMOS/plandev
Create Tests for EventGraphEvaluator
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 128
- Forks
- 33
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 12
Description
EventGraphEvaluator has two implementations: RecursiveEventGraphEvaluator and IterativeEventGraphEvaluator, and while the Recursive evaluator is used as a tool in a test, we never test that these classes output what they're supposed to.
This ticket will:
- Add these tests
- Add JavaDoc comments to
EventGraphEvaluator(There JavaDocs onEffectTraitandEffectExpressionshould be useful)
In the event that IterativeEventGraphEvaluator is not correct, we should evaluate if we would like to maintain it, given that it is currently unused code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating EventGraphEvaluator and its RecursiveEventGraphEvaluator and IterativeEventGraphEvaluator implementations. Read the JavaDocs on EffectTrait and EffectExpression, then inspect the existing test usage of the recursive evaluator. Done means both evaluators have tests for their output and EventGraphEvaluator has JavaDoc; any iterative-evaluator defect should be assessed for continued maintenance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100